🐛 <listbox/> with transtion open on "enter" click #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
far-fetched
commented
May 27, 2022
| </Listbox>`); | ||
|
|
||
| getListboxButton()?.focus(); | ||
| userEvent.keyboard('{Enter}'); |
There was a problem hiding this comment.
Unfortunately, triggerEvent from ember-helpers does not simulate "Enter" like real browser. Only one handler is executed, thus this test would pass even without a fix for the relevant issue.
There was a problem hiding this comment.
Does the testing library util here do the whole series of events that occur when pressing keys?
There was a problem hiding this comment.
Yes, similar emulation we used with dialog test for tab press.
far-fetched
force-pushed
the
fix-listbox-open-on-enter-click
branch
from
917854b to
4c9033f
Compare
|
Thanks for doing this!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed and why:
Currently when using
<Listbox/>component with composition with<Transtion/>it is not possible to use "Enter" key to open listbox.Video from demo (try yourself):
simplescreenrecorder-2022-05-27_12.14.46.mp4
Fix:
listbox with transition suffers from race condition. When “enter” click, handler for
keyPressis called – is sets flagisOpento true.Then after a while, the handler
onButtonClickis also fired – this handler togglesisOpenproperty – so it revertsisOpento false.Everything above is executed on one “enter” click.
link to failed test.